- {keepRenderableFavorites(favorites).map((item) => (
+ {renderableFavorites.map((item) => (
- {history.length === 0 ? (
+ {renderableHistory.length === 0 ? (
) : (
- {keepRenderableHistory(history).map((item) => (
+ {renderableHistory.map((item) => (
0 : typeof videoId === 'number';
+ const hasVideoId = typeof videoId === 'string'
+ ? videoId.trim().length > 0
+ : typeof videoId === 'number' && Number.isFinite(videoId);
- return hasVideoId && typeof record.source === 'string' && typeof record.title === 'string';
+ return hasVideoId &&
+ typeof record.source === 'string' && record.source.trim().length > 0 &&
+ typeof record.title === 'string' && record.title.trim().length > 0;
}
/**
* Records restored from server-side sync are not guaranteed to be well formed —
* they may come from an older schema or a partial write. Rendering one without
- * `videoId` throws while building the player URL, which takes down the whole
- * page, so anything lacking a usable identity is dropped on the way in.
+ * `videoId` or `episodeIndex` throws while building the player URL, which takes
+ * down the whole page, so anything lacking the required URL fields is dropped.
*/
export function isRenderableHistoryItem(value: unknown): value is VideoHistoryItem {
- return hasIdentity(value);
+ if (!hasIdentity(value)) return false;
+ const episodeIndex = (value as { episodeIndex?: unknown }).episodeIndex;
+ return typeof episodeIndex === 'number' && Number.isInteger(episodeIndex) && episodeIndex >= 0;
}
export function isRenderableFavoriteItem(value: unknown): value is FavoriteItem {
diff --git a/package-lock.json b/package-lock.json
index 174dc86..0d3f2fb 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "kvideo",
- "version": "4.9.18",
+ "version": "4.9.19",
"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "kvideo",
- "version": "4.9.18",
+ "version": "4.9.19",
"dependencies": {
"@dnd-kit/core": "^6.3.1",
"@dnd-kit/sortable": "^10.0.0",
diff --git a/package.json b/package.json
index 6f7b193..be2e709 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "kvideo",
- "version": "4.9.18",
+ "version": "4.9.19",
"private": true,
"scripts": {
"dev": "node scripts/next-with-lan-access.mjs dev",
diff --git a/tests/douban-image-fallback.test.ts b/tests/douban-image-fallback.test.ts
new file mode 100644
index 0000000..c15f121
--- /dev/null
+++ b/tests/douban-image-fallback.test.ts
@@ -0,0 +1,54 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+
+import { GET } from '@/app/api/douban/image/route';
+import { buildDoubanImageCandidates } from '@/lib/server/douban-image';
+
+test('Douban image candidates preserve the path and try reachable mirrors', () => {
+ const candidates = buildDoubanImageCandidates(
+ 'https://img1.doubanio.com/view/photo/s_ratio_poster/public/p123.webp?x=1',
+ );
+
+ assert.deepEqual(candidates, [
+ 'https://img1.doubanio.com/view/photo/s_ratio_poster/public/p123.webp?x=1',
+ 'https://img9.doubanio.com/view/photo/s_ratio_poster/public/p123.webp?x=1',
+ 'https://img3.doubanio.com/view/photo/s_ratio_poster/public/p123.webp?x=1',
+ 'https://img2.doubanio.com/view/photo/s_ratio_poster/public/p123.webp?x=1',
+ ]);
+});
+
+test('non-Douban and malformed URLs are attempted only once', () => {
+ assert.deepEqual(buildDoubanImageCandidates('https://example.com/poster.jpg'), [
+ 'https://example.com/poster.jpg',
+ ]);
+ assert.deepEqual(buildDoubanImageCandidates('not a url'), ['not a url']);
+});
+
+test('image proxy falls back after a mirror network failure', async (context) => {
+ const requested: string[] = [];
+
+ context.mock.method(globalThis, 'fetch', async (input: string | URL | Request) => {
+ const url = input.toString();
+ requested.push(url);
+
+ if (url.includes('img1.doubanio.com')) {
+ throw new TypeError('fetch failed');
+ }
+
+ return new Response('image-bytes', {
+ status: 200,
+ headers: { 'content-type': 'image/webp' },
+ });
+ });
+
+ const target = encodeURIComponent('https://img1.doubanio.com/poster.webp');
+ const response = await GET(new Request(`https://kvideo.test/api/douban/image?url=${target}`));
+
+ assert.equal(response.status, 200);
+ assert.equal(response.headers.get('content-type'), 'image/webp');
+ assert.equal(await response.text(), 'image-bytes');
+ assert.deepEqual(requested, [
+ 'https://img1.doubanio.com/poster.webp',
+ 'https://img9.doubanio.com/poster.webp',
+ ]);
+});
diff --git a/tests/sync-records.test.ts b/tests/sync-records.test.ts
new file mode 100644
index 0000000..963f7ec
--- /dev/null
+++ b/tests/sync-records.test.ts
@@ -0,0 +1,41 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+
+import {
+ keepRenderableFavorites,
+ keepRenderableHistory,
+} from '@/lib/utils/sync-records';
+
+const validIdentity = {
+ videoId: 'video-1',
+ source: 'source-a',
+ title: 'Example',
+};
+
+test('sync record filters reject malformed identities', () => {
+ assert.deepEqual(keepRenderableFavorites([
+ validIdentity,
+ { ...validIdentity, videoId: undefined },
+ { ...validIdentity, videoId: Number.NaN },
+ { ...validIdentity, source: '' },
+ { ...validIdentity, title: ' ' },
+ null,
+ ]), [validIdentity]);
+});
+
+test('history records require a usable episode index', () => {
+ const validHistory = { ...validIdentity, episodeIndex: 0 };
+
+ assert.deepEqual(keepRenderableHistory([
+ validHistory,
+ { ...validIdentity },
+ { ...validIdentity, episodeIndex: -1 },
+ { ...validIdentity, episodeIndex: 1.5 },
+ { ...validIdentity, episodeIndex: '0' },
+ ]), [validHistory]);
+});
+
+test('sync record filters tolerate non-array payloads', () => {
+ assert.deepEqual(keepRenderableHistory({ history: [] }), []);
+ assert.deepEqual(keepRenderableFavorites(undefined), []);
+});